Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enforce number type on spring and tweened #14841

Closed
wants to merge 14 commits into from
Closed

fix: enforce number type on spring and tweened #14841

wants to merge 14 commits into from
+589 −535

Conversation

Ocean-OS
Copy link
Contributor

Fixes #14840 by adding extends number to the type annotations in svelte/motion.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14841

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 26, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 84bcab9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Ocean-OS
Copy link
Contributor Author

Could someone please assist with formatting? I'm currently using my phone to do this.

@webJose
Copy link
Contributor

webJose commented Dec 28, 2024

Update it or close it. You seem to have hasted onto my initial (and incorrect) assertion that springs could only handle numbers. If you wish to collaborate, base your PR on #14851.

@Ocean-OS Ocean-OS closed this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spring isn't deeply reactive (target cannot be mutated)
2 participants
@Ocean-OS @webJose